Add interceptor and event listener support for NavigationRoute #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Feb 12, 2019
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks for these updates @danesfeder, let's merge when 4.4.0 is good to go 
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
============================================
+ Coverage 30.01% 30.06% +0.05%
Complexity 843 843
============================================
Files 220 220
Lines 8147 8153 +6
Branches 629 629
============================================
+ Hits 2445 2451 +6
Misses 5471 5471
Partials 231 231 |
danesfeder
force-pushed
the
dan-expose-interceptor
branch
2 times, most recently
from
c59d276 to
c5ab0b9
Compare
danesfeder
force-pushed
the
dan-expose-interceptor
branch
from
c5ab0b9 to
9e3b7bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
NavigationRoute.Builder#interceptorandNavigationRoute.Builder#eventListener. For customizing / listening to the underlyingOkHttpframework running our route requests.