Update InstructionLoader API as public / taking BannerText #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
=========================================
Coverage 26.69% 26.69%
Complexity 823 823
=========================================
Files 202 202
Lines 8533 8533
Branches 627 627
=========================================
Hits 2278 2278
Misses 6042 6042
Partials 213 213 |
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Could we cut a different PR with the offline changes? Those are unrelated to the scope of this PR 😬
danesfeder
changed the title
danesfeder
reviewed
Jan 16, 2019
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
One minor comment, thanks for the quick update here @devotaaabel
...rc/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/InstructionLoader.java
Show resolved
Hide resolved
devotaaabel
force-pushed
the
devota-update-apis
branch
from
51556ef to
b6a0fde
Compare
…xt object instead of a list of BannerComponents
devotaaabel
force-pushed
the
devota-update-apis
branch
from
b6a0fde to
6479c2a
Compare
danesfeder
approved these changes
Jan 16, 2019
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @devotaaabel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
InstructionLoaderAPI and removed the multiple instantiations ofMapboxOfflineRouterinOfflineRegionDownloadActivity