Remove unused / package-private RouteStepProgress#nextStep #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Jan 14, 2019
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks for the quick fix here @danesfeder 
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
============================================
- Coverage 26.5% 26.45% -0.05%
Complexity 795 795
============================================
Files 197 197
Lines 8392 8387 -5
Branches 602 600 -2
============================================
- Hits 2224 2219 -5
Misses 5968 5968
Partials 200 200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1665
This may be residual code / cleanup missed from the
Navigatorintegration, butRouteStepProgress#nextStepis not used and is package-private. It's creation in theRouteLegProgressis causing the crash.All tests run fine and it's better to get this "creation logic" out of the object itself.