Allow NavigationView to start navigation during existing session #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
============================================
+ Coverage 25.58% 25.93% +0.34%
- Complexity 772 779 +7
============================================
Files 197 197
Lines 8365 8368 +3
Branches 600 601 +1
============================================
+ Hits 2140 2170 +30
+ Misses 6030 5998 -32
- Partials 195 200 +5 |
danesfeder
force-pushed
the
dan-way-point
branch
from
8571589 to
cf03f6e
Compare
Guardiola31337
approved these changes
Jan 9, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was introduced in #1622:
#1622 was created to prevent duplicate voice instructions from firing during configuration changes.
This PR removes the checks in
NavigationViewRouteEngineListenerand rather checks for configuration changes in theNavigationViewModel. This will prevent the duplicate voice instruction but also allow developers to start navigation while a session is running (regardless off off-route or first-route).