Skip to content

Add listener for updates to map way name #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danesfeder merged 1 commit into from
Nov 20, 2018
Merged

Add listener for updates to map way name #1544

danesfeder merged 1 commit into from
Nov 20, 2018

Conversation

@danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Nov 18, 2018

Closes #1405

Thanks for the original work / digging on this @tobrun

@danesfeder danesfeder added this to the v0.24.0 milestone Nov 18, 2018
@danesfeder danesfeder self-assigned this Nov 18, 2018
@danesfeder
Copy link
Contributor Author

danesfeder commented Nov 18, 2018

Issue with Robolectric test coverage reporting seems to persist.
The code marked as not covered is actually being covered by tests I added in the PR: https://codecov.io/gh/mapbox/mapbox-navigation-android/compare/5defa224a66da06835368f1de375f4c753458e5b...9d8f15e33cf440c4ec56a07e94faa053f7ef5da2

@danesfeder danesfeder force-pushed the dan-wayname-listener branch 2 times, most recently from 13f8b9f to d95b9a9 Compare November 20, 2018 17:46
Guardiola31337
Guardiola31337 approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danesfeder :shipit:

@danesfeder danesfeder merged commit 4ab858b into master Nov 20, 2018
@danesfeder danesfeder deleted the dan-wayname-listener branch November 20, 2018 18:08
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 30, 2018
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danesfeder danesfeder

Labels

feature New feature request.

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@danesfeder @Guardiola31337