-
Notifications
You must be signed in to change notification settings - Fork 320
Add RouteProgressState to RouteProgress for current Navigator information #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey Dan, Thanks, |
| // Class should not be initialized | ||
| } | ||
|
|
||
| @IntDef({ROUTE_INVALID, ROUTE_INITIALIZED, ROUTE_ARRIVED, LOCATION_TRACKING, LOCATION_STALE}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have OFF ROUTE as well? technically if you dont do a re-route you will stay off route until you get back on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's not needed because of
Line 15 in 6922783
| put(RouteState.OFFROUTE, null); // Ignore off-route (info already provided via listener) |
|
currentState() in RoutrProgress.java is not available in current version 0.22.0 of navigation sdk. Can you please let me know when you are going to publish it? |
6922783 to
7caaa06
Compare
7caaa06 to
854a053
Compare
|
@Guardiola31337 I converted |
Guardiola31337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback @danesfeder 🙇
🚢
Closes #1501 @navdeepg to confirm
This is an example of a last step from the Directions API (containing the maneuver type
"arrive"):As you can see, the step has a single point that represents the geometry.
Navigatorignores the step, making it impossible for a user to be "on the step" and havemaneuver type == "arrive".This PR adds a
RouteProgressStatethat not only gives information about when a user has arrived, but also a lot of other information given to us via theNavigatorRouteState. Even if we did allow navigation on this step, it would be very hard to get a location update that was snapped to this geometry.Example usage to detect when a user has arrived at the end of the given
RouteLeg:This is marked
SEMVERbecause it breaksRouteUtils.cc @kevinkreiser