Fix via waypoints APIs naming

[Guardiola31337]

• Follow up from Add via waypoints support to MapboxDirections #959

We found in mapbox/mapbox-navigation-android#1733 (comment) that naming could be confusing and should be more explicit in order to make clients' life easier.

[danesfeder]

Thanks for this update @Guardiola31337

[osana]

@Guardiola31337
If we are doing this name change, we should do a similar name change in MapboxMapMatching
I guess we can deprecate the use of waypoints and add viawaypoints (for now)

Also please add viawaypoints to RouteOptions

[akitchen]

This was correct as-was. Should be waypoints as one word, no capital P

[Guardiola31337]

Yeah, you're correct. Will update in a follow-up PR. Thanks for flagging 🙇

[Guardiola31337]

@osana

If we are doing this name change, we should do a similar name change in MapboxMapMatching
I guess we can deprecate the use of waypoints and add viawaypoints (for now)

Yeah, I agree. We should be consistent across the different services. Will implement ☝️ if we're not cool breaking SemVer.

Also please add viawaypoints to RouteOptions

You mean, adding "waypoints" option to Map Matching route options, right? I've already added it to Directions 👀

mapbox-java/services-directions/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java

Line 284 in 57e8710

public abstract String viaWayPoints();

mapbox-java/services-directions/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java

Line 569 in 57e8710

public abstract Builder viaWayPoints(@Nullable String indices);

[osana]

@Guardiola31337 Please add a call to viaWaypoints() when RouteOptions are being saved/generated:

mapbox-java/services-directions/src/main/java/com/mapbox/api/directions/v5/MapboxDirections.java

Line 235 in 6e6110a

RouteOptions.builder()

I believe tests might be updated as well.