This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Show tile collision and parser status when building Debug #15855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have a visual clue that it is a debug build.
|
@julianrex @tobrun @zugaldia this should affect debug builds of the SDK. The idea is to have some visual clue so developers will not accidentally work on a debug build when the intention is the work on a release build (and vice-versa). |
|
cc @mapbox/maps-android @mapbox/maps-ios |
|
👍 I'm a big fan of watermarks for build variants - would like to add something for iOS too. |
|
@tmpsantos what is blocking this merge? |
|
Looks like it still requires a review from @julianrex and @alexshalamov? |
|
I need to find time to rebase it. :-| |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a visual clue that it is a debug build.