This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios, darwin] Make MGLFeature.attributes non-nullable and add integration test #13543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
reviewed
Dec 11, 2018
julianrex
reviewed
Dec 11, 2018
julianrex
approved these changes
Dec 11, 2018
Contributor
julianrex
left a comment
julianrex
left a comment
There was a problem hiding this comment.
Just the question about whether the test should be part of this PR, but otherwise 👍
alexshalamov
changed the title
alexshalamov
force-pushed
the
alexshalamov_fix_for_13378
branch
from
d3a1d2b to
dccc06f
Compare
1ec5
reviewed
Dec 11, 2018
alexshalamov
force-pushed
the
alexshalamov_fix_for_13378
branch
2 times, most recently
from
1f34949 to
4863d0e
Compare
alexshalamov
changed the title
1ec5
approved these changes
Dec 12, 2018
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
Looks good! I feel better about the integration test now that its timeout is only a second long, though it would be nice to have a unit test at some point. Would you do the honors and add iOS and macOS changelog entries along these lines?
Fixed a crash when specifying
MGLShapeSourceOptionLineDistanceMetricswhen creating anMGLShapeSource.
alexshalamov
force-pushed
the
alexshalamov_fix_for_13378
branch
from
4863d0e to
dbfe111
Compare
…tion test Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties from nil NSDictionary object and align with public SDK property definition. Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted. Fixes issue #13378
alexshalamov
force-pushed
the
alexshalamov_fix_for_13378
branch
from
dbfe111 to
b232873
Compare
friedbunny
added
iOS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce non-nullable semantics for MGLFeature.attributes, to avoid construction of invalid mbgl::Feature properties from nil NSDictionary object and align with public SDK property definition.
Integration test "testShapeSourceWithLineDistanceMetrics" is added to verify that MGLFeature is correctly converted.
Fixes issue #13378