Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Per-property transitions are not parsed from style #7863

Closed
1ec5 opened this issue Jan 25, 2017 · 2 comments
Closed

Per-property transitions are not parsed from style #7863

1ec5 opened this issue Jan 25, 2017 · 2 comments
Assignees
Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 25, 2017

16c435b inadvertently removed the call to parseTransitionOptions() and thus support for per-property transitions in style JSON. This would represent a regression from iOS SDK v3.3.x and Android SDK v4.1.0.

Per mapbox/mapbox-gl-js#2788, mapbox/mapbox-gl-style-spec#171, and mapbox/mapbox-gl-test-suite#116, the current plan is to give per-property transitions all the trappings of a formal style specification feature, so here’s one more: the developer might expect to be able to configure per-property transitions using the runtime styling API, now that they can configure style-wide transitions (#7711).

/cc @jfirebaugh @incanus

@1ec5 1ec5 added bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS runtime styling labels Jan 25, 2017
@1ec5 1ec5 added this to the ios-v3.5.0 milestone Jan 25, 2017
@jfirebaugh jfirebaugh self-assigned this Feb 9, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 9, 2017

the developer might expect to be able to configure per-property transitions using the runtime styling API

#8010 tracks adding runtime styling support for per-attribute transitions to the iOS and macOS SDKs.

@incanus
Copy link
Contributor

incanus commented Feb 9, 2017

Just as a point of clarification, since I was a little fuzzy on this, having e.g. a value for text-color-transition in the original style would cause runtime styling changes to text-color to transition. And then #8010 exposes such transition properties in code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS runtime styling
Projects
None yet
Development

No branches or pull requests

3 participants