Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document, test, and port (or deprecate) per-layer and per-property transitions #2788

Closed
lucaswoj opened this issue Jun 27, 2016 · 2 comments
Closed

Comments

@lucaswoj
Copy link
Contributor

GL JS supports per-property transitions (i.e. circle-color-transition) and per-layer transitions. These features are not documented, tested, or ported to GL Native. We should either

  • document, test, and port this feature
  • deprecate this feature

cc @mapbox/gl @geohacker

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Jun 28, 2016

per-layer transitions

Are you sure about this? As far as I know it supports per-property transitions and a style-wide default. gl-native does as well.

Documentation: mapbox/mapbox-gl-style-spec#171
Testing: mapbox/mapbox-gl-test-suite#116

Deprecation / removal is another alternative. Per-property transitions are not widely used. In fact I'm not aware of any production use.

@lucaswoj
Copy link
Contributor Author

Are you sure about this?

Nope. A user was complaining that this feature stopped working. I was unaware that we ever supported per-layer transitions but gave them benefit of the doubt.

Seeing as these mapbox/mapbox-gl-style-spec#171 and mapbox/mapbox-gl-test-suite#116 are more actionable, let's focus on those 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants