This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Replace NSArray with more specific types in runtime styling API #5947
Assignees
Labels
Milestone
Comments
|
Per #5727 (comment), the order inside |
This was referenced Aug 18, 2016
1ec5
added a commit
that referenced
this issue
Aug 18, 2016
An offset style attribute is now exposed publicly as an NSValue representing a CGVector instead of an NSArray of NSNumbers. A padding style attribute is now exposed publicly as an NSValue representing an NSEdgeInsets or UIEdgeInsets instead of an NSArray of NSNumbers. This change also fixes round-tripping of padding values due to a difference between the style specification and Foundation regarding the order of edges around a box. Used a designated initializer on NSEdgeInsets/UIEdgeInsets to ensure correct order when converting from C++ to Objective-C. Fixes #5947, fixes #6065.
1ec5
added a commit
that referenced
this issue
Aug 19, 2016
An offset style attribute is now exposed publicly as an NSValue representing a CGVector instead of an NSArray of NSNumbers. A padding style attribute is now exposed publicly as an NSValue representing an NSEdgeInsets or UIEdgeInsets instead of an NSArray of NSNumbers. This change also fixes round-tripping of padding values due to a difference between the style specification and Foundation regarding the order of edges around a box. Used a designated initializer on NSEdgeInsets/UIEdgeInsets to ensure correct order when converting from C++ to Objective-C. Fixes #5947, fixes #6065.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Per #5727 (comment), we should use types other than NSArray to represent fixed-length collections in the style specification:
centerasCLLocationCoordinate2Dfill-translate,line-translate,icon-offset,text-offset,icon-translate,text-translate,circle-translateasCGVector(-mbgl_offsetPropertyValueWith:)text-offsetis a good example of whyCGVectoris preferable toNSPoint/CGPoint: its unit is ems rather than screen pointsline-dasharrayasNSArray<NSNumber *> *icon-text-fit-paddingasNSEdgeInsets/UIEdgeInsets(-mbgl_paddingPropertyValueWith:)text-fontasNSArray<NSFontDescriptor *> */NSArray<UIFontDescriptor *> */cc @frederoni @incanus
The text was updated successfully, but these errors were encountered: