Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for non-integer devicePixelRatio #4989

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Conversation

jfirebaugh
Copy link
Contributor

This was my bad -- broken by sprite atlas refactoring in #4737.

Fixes #4928
Fixes #4960

Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for tracking this down. Working for me locally, just one question about the package.json changes.

package.json Outdated
@@ -127,8 +127,8 @@
"test-suite": "run-s test-render test-query",
"test-suite-clean": "find test/integration/*-tests -mindepth 2 -type d -not \\( -exec test -e \"{}/style.json\" \\; \\) -print | xargs -t rm -r",
"test-unit": "tap --reporter dot --no-coverage test/unit",
"test-render": "node test/render.test.js",
"test-query": "node test/query.test.js",
"test-render": "node $NODE_DEBUG_OPTION test/render.test.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to leave these $NODE_DEBUG_OPTIONs in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants