Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wordmark in IE #4741

Merged
merged 1 commit into from
May 23, 2017
Merged

fix wordmark in IE #4741

merged 1 commit into from
May 23, 2017

Conversation

mollymerp
Copy link
Contributor

@mollymerp mollymerp commented May 23, 2017 •
edited
Loading

fix #4739

IE doesn't support <style/> tags in SVG, so I re-encoded a version of the wordmark with inline styles. Tested this on browserstack with IE 11+ Windows 10 and its looking good.

cc @tristen

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp mollymerp merged commit 02dfbb1 into master May 23, 2017
@mollymerp mollymerp deleted the ie-wordmark branch May 23, 2017 12:20
chrisvoll pushed a commit to chrisvoll/mapbox-gl-js that referenced this pull request May 25, 2017
@mollymerp @chrisvoll
fix wordmark in IE (mapbox#4741)
5596a23
@jmunowitch jmunowitch mentioned this pull request Sep 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapbox watermark not rendering opacity in IE
2 participants
@mollymerp @mourner