showCollisionBoxes fix #4689
Merged
showCollisionBoxes fix #4689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2017 17:21
…ollisionBoxes is set to true
|
Can you test the added integration test in native and add an ignore or skip if needed? 🙇 |
jfirebaugh
reviewed
May 9, 2017
| "wait" | ||
| ], | ||
| [ | ||
| "showCollisionBoxes" |
There was a problem hiding this comment.
is similar, but with different terminology. Can we make consistent?
|
ty @jfirebaugh 👍 tested on native and made all collision box tests consistent. |
|
🍏 |
|
@asheemmamoowala thanks! I still need an Official ✅ Review to be able to merge this 😸 |
asheemmamoowala
approved these changes
May 24, 2017
chrisvoll
pushed a commit
to chrisvoll/mapbox-gl-js
that referenced
this pull request
May 25, 2017
* fire when redoing placement so collision boxes show up when map.showCollisionBoxes is set to true * add collision box test * make render tests consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4647
When I was refactoring the
dataevents in #4347 it appeared that thisfirewas unnecessary because I didn't think to check theshowCollisionBoxesfeature. Now we have a test to catch something like that in the future 😅Launch Checklist