Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill_outline shader invokes undefined behavior #4600

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Apr 18, 2017

@jfirebaugh discovered in mapbox/mapbox-gl-native#8751 that we are using undefined behavior in the fill_outline shader:

float alpha = smoothstep(1.0, 0.0, dist);

It seems that some implementations correctly interpolate between 1.0 and 0.0 based on the t value, but per the spec, it's undefined behavior.

@mourner mourner merged commit 6f42d00 into master Apr 18, 2017
@mourner mourner deleted the 4600-fill_outline-undefined-behavior branch April 18, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants