Fix bug calculating image source tile coordinates #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4550 Using `Math.round` on the `centerCoord` value here causes a coordinate like `{zoom: 2, column: 1.5, row: 1.5}` to become `{zoom: 2, column: 2, row: 2}`, which is out of bounds for a z2 tile; the correct tile for containing those coordinates is `{zoom: 2, column: 1, row: 1}`
mourner
approved these changes
Apr 6, 2017
|
Can you add a regression test for this? |
anandthakker
pushed a commit
that referenced
this pull request
Apr 6, 2017
Accidentally left out of #4553
|
@jfirebaugh oops I must have failed to |
anandthakker
added a commit
that referenced
this pull request
Apr 6, 2017
Accidentally left out of #4553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4550
Using
Math.roundon thecenterCoordvalue here causes a coordinatelike
{zoom: 2, column: 1.5, row: 1.5}to become{zoom: 2, column: 2, row: 2}, which is out of bounds for a z2 tile;the correct tile for containing those coordinates is
{zoom: 2, column: 1, row: 1}