Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return from keyboard handler on non-action key. #4533

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Return from keyboard handler on non-action key. #4533

merged 1 commit into from
Apr 4, 2017

Conversation

jasonpepper
Copy link
Contributor

@jasonpepper jasonpepper commented Apr 3, 2017

Added a return statement to the keyboard handler when a non-action key is pressed. In certain environments, holding down the shift key was triggering numerous calls to the easeTo method which was interfering with the easeTo call in the shift zoom. This fixes issue #3334.

@jfirebaugh jfirebaugh requested a review from mollymerp April 3, 2017 14:03
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@mourner mourner merged commit 3a19437 into mapbox:master Apr 4, 2017
@jasonpepper jasonpepper deleted the keyboard-handler-return branch April 4, 2017 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants