Respect img height/width in addImage api #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user passes an image tag with a height and width that differ from the native height and width of the src, mapbox should respect the user's choice and draw the scaled image.
jfirebaugh
force-pushed
the
respect-img-tag-height-and-width
branch
from
f126a3b
to
9be6e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user passes an
imgtag with a height and width that differ from the native height and width of the source image, mapbox should respect the user's choice and draw the scaled image. Currently mapbox draws image at its native size and then clips it to fit the specified height/width, which is unintuitive.Example:
I use
addImageto add this image tag. It's a 64x64 png natively, but I want to pretend it's 32x32.When mapbox draws it, I see: