Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dds support for text-offset #4495

Merged
merged 2 commits into from
Mar 27, 2017
Merged

add dds support for text-offset #4495

merged 2 commits into from
Mar 27, 2017

Conversation

mollymerp
Copy link
Contributor

@mollymerp mollymerp commented Mar 25, 2017

close #4435

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new integration tests, I've been trying to make them more minimal and deterministic by using a GeoJSON source with a small number of geometries. Here's a typical example.

Copy link
Contributor

@lucaswoj lucaswoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The new render test is 🎨 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DDS support for "text-offset"
3 participants