Tested some uncovered parts of the src/ui module #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Mar 15, 2017
|
Thanks for all your testing work @joswinter !! 🙇♀️ |
andrewharvey
pushed a commit
to andrewharvey/mapbox-gl-js
that referenced
this pull request
Mar 17, 2017
* Add hash#onHashChange test
* Added Map#{moveLayer,getLayer} tests
* Added DragRotateHandler#disable test
* Fixed incorrect code styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not change any functionality of the system. It only contains improvements for the testing suite.
The
src/uimodule contained some untested functionality. I added a test for the untestedHash#onHashChangemethods. I added a test for themoveLayerandgetLayermethods in theMapclass. Lastly, I added a test for theDragRotateHandler#disablemethod.