Tested some uncovered parts of the src/style and scr/style-spec module #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Mar 15, 2017
andrewharvey
pushed a commit
to andrewharvey/mapbox-gl-js
that referenced
this pull request
Mar 17, 2017
mapbox#4431) * Tested setTransition behaviour in diff#diffStyles * Tested incorrect url match behaviour in composite * Tested color_spaces#hcl.{forward,reverse} * Tested migrate function on different input * Tested uncovered behaviour in StyleLayer * Fixed incorrect identation in migrate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not change any functionality of the system. It only contains improvements for the testing suite. The
src/styleandscr/style-specmodule contain untested functionality. I added tests for the following methods in thesrc/stylemodule:setPaintProperty,getPaintValueStopZoomLevelsand theisPaintValueZoomConstantmethod of theStyleLayerclassI added tests for the following methods in the
src/style-specmodule:migratefunctioncolor_spacesfunctionscompositefunctiondiff#diffStylesfunctionThese added tests improve the line coverage in the
src/styleandsrc/style-specmodule with 20 additional covered lines which is about +0,2% line coverage.