Make sure parent tiles are retained for fading #4034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2467
@mourner The issue was that
SourceCache#update()
gets called after a tile is loaded, but beforedrawRasterTile()
has had a chance to calltile.registerFadeDuration
for the first. since we were usingtile.fadeEndTime
to decide whether to retain parents/children for fading, the children get removed from the source cache as soon as the tile is loaded.Launch Checklist