Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix garbled text on zoom #3962

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Fix garbled text on zoom #3962

merged 1 commit into from
Jan 13, 2017

Conversation

mourner
Copy link
Member

@mourner mourner commented Jan 12, 2017

Fixes #3669. Sorry for regressing this. The bug happened when different tiles of the same symbol layer had different fontstacks, which can sometimes happen during zoom when only a part of tiles is parsed before rendering.

I have no idea how to add a regression test for this though because it only happens intermittently and depends on a lot of factors like network speed, etc. So I suggest merging this without a test for now.

frame-duration benchmark shows no difference.

@mourner mourner requested a review from lucaswoj January 12, 2017 15:04
@lucaswoj
Copy link
Contributor

lucaswoj commented Jan 13, 2017

I have no idea how to add a regression test for this though because it only happens intermittently and depends on a lot of factors like network speed, etc. So I suggest merging this without a test for now.

There have been so many untestable regressions lately. 😞 It might be time to invest in some test suite infrastructure for controlling network requests & the clock. I'll open some tickets.

@mourner mourner merged commit ac70fa7 into master Jan 13, 2017
@mourner mourner deleted the fix-text-garbling branch January 13, 2017 15:40
@mourner
Copy link
Member Author

mourner commented Jan 13, 2017

@lucaswoj alternatively, we could add a semi-private API for explicitly loading a set of specified tiles and bypassing the source-cache pyramid logic; this way we would also be able to more easily test overscaled tiles, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants