Add data-driven styling support for "icon-offset" #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
reviewed
Dec 13, 2016
| @@ -295,7 +295,8 @@ class SymbolBucket { | |||
| let shapedIcon; | |||
| if (feature.icon) { | |||
| const image = icons[feature.icon]; | |||
| shapedIcon = shapeIcon(image, layout); | |||
| const iconOffset = this.layers[0].getLayoutValue('icon-offset', {}, feature.properties); | |||
There was a problem hiding this comment.
Second argument to getLayoutValue should be {zoom: this.zoom}.
There was a problem hiding this comment.
Good catch. This will require an update of mapbox-gl-test-suite.
There was a problem hiding this comment.
Fixed & ready for final 👀
lucaswoj
force-pushed
the
icon-offset-dds
branch
from
cb9ac81
to
823803d
Compare
jfirebaugh
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3729
Related to mapbox/mapbox-gl-test-suite#194