Do not require passing WebGL context in order to destroy buffers/VAOs #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors Unique{Buffer,VAO} in native: a reference to the context is necessary to create, but the resulting object knows how to destroy itself without additional arguments.
It also reduces the number of places where Source objects need a painter or map reference.
mourner
approved these changes
Oct 12, 2016
anandthakker
pushed a commit
that referenced
this pull request
Mar 13, 2017
extends #3351 which changed the function unloadVectorData to take 0 parameters instead of 1. * FIX unloadVectorData call with 1 argument where 0 are expected * Changed test to assert that unloadVectorData is called with 0 parameters before overwriting
andrewharvey
pushed a commit
to andrewharvey/mapbox-gl-js
that referenced
this pull request
Mar 17, 2017
extends mapbox#3351 which changed the function unloadVectorData to take 0 parameters instead of 1. * FIX unloadVectorData call with 1 argument where 0 are expected * Changed test to assert that unloadVectorData is called with 0 parameters before overwriting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors
Unique{Buffer,VAO}in native: a reference to the context is necessary to create, but the resulting object knows how to destroy itself without additional arguments.It also reduces the number of places where
Sourceobjects need a painter or map reference (#3350).