Skip to content

Emit errors from query*Features, rather than throwing them #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2016
Merged

Emit errors from query*Features, rather than throwing them #3209

merged 1 commit into from
Sep 19, 2016

Conversation

jfirebaugh
Copy link
Contributor

Fixes #3208

mollymerp
mollymerp approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for making us consistent about this!

@jfirebaugh jfirebaugh merged commit 93c3b03 into master Sep 19, 2016
@jfirebaugh jfirebaugh deleted the emit-errors branch September 19, 2016 16:11
jfirebaugh added a commit that referenced this pull request Sep 19, 2016
@jfirebaugh
Remove dead code
617bf06 
This code is unused following #3209.
mourner pushed a commit that referenced this pull request Sep 20, 2016
@jfirebaugh @mourner
Avoid unnecessary style validation (#3224)
07feb8d 
* Remove dead code

This code is unused following #3209.

* Avoid unnecessary style validation

* Don't validate mapbox:// styles
* Don't validate data in the worker
* Don't revalidate previously-validated data
captainbarbosa pushed a commit that referenced this pull request Oct 3, 2016
@jfirebaugh @captainbarbosa
Avoid unnecessary style validation (#3224)
13a2008 
* Remove dead code

This code is unused following #3209.

* Avoid unnecessary style validation

* Don't validate mapbox:// styles
* Don't validate data in the worker
* Don't revalidate previously-validated data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @mollymerp