Blazing fast layer update #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, could you do a jsfiddle that includes this patch so we can compare? |
|
@tmcw yes, was waiting for the build to complete. |
|
JSFiddle with the new build (inlined) that demonstrates the performance: https://jsfiddle.net/Mourner/0Lk8awwp/3/ |
|
Added another optimization that affects the example — avoid triggering an update when you set filter, layout property or zoom range to values that are already set. |
| @@ -14,7 +14,8 @@ function styleBatch(style, work) { | |||
|
|
|||
| batch._style = style; | |||
| batch._groupLayers = false; | |||
| batch._broadcastLayers = false; | |||
| batch._broadcastAllLayers = false; | |||
| batch._broadcastLayers = {}; | |||
There was a problem hiding this comment.
It's a little tricky that this._broadcastLayers and this._style._broadcastLayers both exist and are of different types
|
I disagree that this 🔥 is so bad that you don't have time to
If you have too much on your plate, I can take care of these tweaks. |
|
This looks great! |
Makes `setLayoutProperty`, `setFilter` and `setLayerZoomRange` much faster by limiting the style->worker transfer to just the updated layers instead of the whole style. Makes this hover example https://jsfiddle.net/0Lk8awwp/1/ fast and smooth again. cc @lyzidiamond @lucaswoj @scothis
This is especially helpful for cases where `setFilter` or `setLayoutProperty` are called on mousemove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
setLayoutProperty,setFilterandsetLayerZoomRangemuch faster by limiting the style->worker transfer to just the updated layers instead of the whole style.Closes #2082 and makes this hover example https://jsfiddle.net/0Lk8awwp/1/ fast and smooth again: https://jsfiddle.net/Mourner/0Lk8awwp/3/
cc @lyzidiamond @lucaswoj @scothis