fix pyramid.findLoadedParent for raster rendering #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.equal(pyramid._cache.order.length, 0); | ||
|
|
||
| // add from retained tiles | ||
| t.deepEqual(pyramid.findLoadedParent(new TileCoord(2, 0, 0), 0, {}), tile); |
There was a problem hiding this comment.
What is this testing? It looks the same as line 669 above.
There was a problem hiding this comment.
findLoadedParent looks for load parent tiles in both the cache and ._tiles (the previous set of tiles).
669 tests whether it works when the tile is in the cache
675 tests whether it works when the tile is in ._tiles
669 moves the tile from the cache to ._tiles internally which is what 672 confirms.
I'll split it up as suggested by https://github.com/mapbox/mapbox-gl-js/pull/2168/files#r53679813
ansis
force-pushed
the
fix-raster-rendering
branch
from
85ec7a6
to
1a5f9b0
Compare
ansis
force-pushed
the
fix-raster-rendering
branch
from
1a5f9b0
to
c8d5441
Compare
|
Looks good now! |
on green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a sloppy bug introduced by e6cb15c
I didn't notice draw_raster was using
findLoadedParentand I didn't test with a raster style.fix #2167
fix #2161
👀 @mourner @lucaswoj