switch geojson units from 4096 to pixels #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 #1967 will need to be updated. |
The units for these GeoJSONSource options changed from 4096 to pixels: - tolerance - buffer - clusterSize To convert an old value to pixels divide by 8. An old value of 400 is the same as 400 / 8 = 50 now. This also increases the default buffer size (how much data padding exists on the sides of the tiles) to 128 pixels. Having a big enough buffer is important for crosstile label placement and to avoid clipping for at tile edges for symbols that are allowed to overlap with each other. This does make the tiles bigger but it think it's worth it.
This was referenced Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The units for these GeoJSONSource options changed from 4096 to pixels:
To convert an old value to pixels divide by 8.
An old value of 400 is the same as 400 / 8 = 50 now.
This is a breaking change.
This also increases the default buffer size (how much data padding exists on the sides of the tiles) to 128 pixels. Having a big enough buffer is important for crosstile label placement and to avoid clipping for at tile edges for symbols that are allowed to overlap with each other. This does make the tiles bigger but it think it's worth it.
👀 @mourner @jfirebaugh @lucaswoj