check response from parseCSSColor before downgrading it as it could be null #2006
Conversation
|
This looks great! Thank you @andrewharvey. I just have one small request before merging: |
|
@lucaswoj Oh I didn't see those tests in style_declaration.test.js, I've updated the commit to include my test in with the others. |
|
Looks great to me @andrewharvey! 🙇 I'm going to give the rest of the team a few more hours to chime in, then merge this into master. |
| colorCache[input] = output; | ||
| return output; | ||
| var parsedColor = parseCSSColor(input); | ||
| if (parsedColor !== null) { |
There was a problem hiding this comment.
Use a guard clause (if (!parsedColor) { throw new Error('Invalid color ' + input); }) and unindent the happy code path.
There was a problem hiding this comment.
Thanks for the style advise. Agreed, much better that way. I've updated the commit.
|
👍 Thank you! |
|
🚢 in 6a18734 |
No description provided.