don't trigger a zoom by 0 #1990
Conversation
| @@ -97,6 +97,7 @@ ScrollZoom.prototype = { | |||
| }, | |||
|
|
|||
| _zoom: function (delta) { | |||
| if (delta === 0) return; | |||
There was a problem hiding this comment.
Would this be more robust as delta < EPSILON?
There was a problem hiding this comment.
maybe, but I don't think it matters in this particular case
There was a problem hiding this comment.
Being more robust always matters! It might fix similar problems on other platforms.
There was a problem hiding this comment.
are you thinking about this from a "floating point issues may cause this check to fail" point of view or a "some legitimately non-zero but still tiny value will trigger a switch to linear but not move the map" view?
There was a problem hiding this comment.
Touching a trackpad with two fingers was triggering a zoom by 0, which was making icons jump around (switching from nearest neighbour to linear interpolation).
I was thinking that another platform might trigger a zoom by 0.000001 in this scenario
There was a problem hiding this comment.
I'm not very concerned, just wondering what your thoughts are
There was a problem hiding this comment.
yeah, I don't have a strong opinion either way, I'm just trying to figure out / learn if that actually makes sense to do this
I'm thinking that since there will always be a cutoff, whether it's epsilon or 0, some values that could be skipped might not be. I think epsilon would be more arbitrary than 0 because it would be just a blind guess. What makes 1 * epsilon a better cutoff than 2 * epsilon or 0.5 * epsilon? What makes 1 * epsilon better than 0 * epsilon?
It would make sense to use a non-zero value if we had real examples, but I don't know if a blind guess for a problem we haven't seen actually improves anything. It seems like it just makes everything a tiny bit more complicated
There was a problem hiding this comment.
fwiw, #1832 covers introducing ε for pan and rotation, but should probably be extended to zoom too.
Touching a trackpad with two fingers was triggering a zoom by 0, which was making icons jump around (switching from nearest neighbour to linear interpolation).
Touching a trackpad with two fingers was triggering a zoom by 0, which was making icons jump around (switching from nearest neighbour to linear interpolation).
look ok @lucaswoj?