Fix easeTo pan, zoom, and rotate when initial rotation != 0 #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -475,10 +475,6 @@ util.extend(Camera.prototype, /** @lends Map.prototype */{ | |||
| this.pitching = true; | |||
| } | |||
|
|
|||
| if (this.zooming && !around) { | |||
| around = tr.pointLocation(tr.centerPoint.add(to.sub(from).div(1 - 1 / scale))); | |||
| } | |||
There was a problem hiding this comment.
As far as I can tell, this code is not needed. There may also be a solution that involves incorporating bearing into the above calculation.
|
👍 the removed code was apparently needed earlier but is not needed after some more recent changes, might be worth looking in git blame. |
|
I'm 90% sure that the "more recent changes" were done by me but I can't find the commit off hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1944
This fixes the bug but might not be the most elegant solution.
👀 💭 @mourner @ansis @1ec5