More intuitive flyTo options #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (Math.abs(u1) < 0.000001) { | ||
| // Perform a more or less instantaneous transition if the path is | ||
| // too short. |
There was a problem hiding this comment.
Why use such a short wrap length for comments? Code lines are much longer.
There was a problem hiding this comment.
How about column 100? f6c0316
|
The API changes look good to me. |
Added flyTo() options that are based on observable properties, so that suitable values can be chosen without guessing and checking. Also documented local variables in flyTo(), based on the paper that describes this algorithm, because the names are non-obvious. Fixes #1854.
1ec5
force-pushed
the
1ec5-flight-options-1854
branch
from
f6c0316 to
1c33dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added flyTo() options that are based on observable properties, so that suitable values can be chosen with less guessing and checking. The
speedandcurveoptions have unfortunate names and are difficult to explain, but I kept them for backwards compatibility. Also documented local variables in flyTo(), based on the paper that describes this algorithm, because the variable names are non-obvious.Fixes #1854. This is a port of mapbox/mapbox-gl-native#3355.
/cc @lucaswoj @mourner