Add altitude attribute to Marker and Popup #13335
Open
+263
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a new property to Marker and Popup that represents the height above the ground. This is very useful for rendering 3D models and marking objects with specific heights. I hope to contribute to the open-source community.
Please read the instructions and review the code, thanks!
Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
![image](https://private-user-images.githubusercontent.com/50374470/389587226-47e721b8-4c67-4f92-a237-84acb57e3776.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODM0NDgsIm5iZiI6MTczOTQ4MzE0OCwicGF0aCI6Ii81MDM3NDQ3MC8zODk1ODcyMjYtNDdlNzIxYjgtNGM2Ny00ZjkyLWEyMzctODRhY2I1N2UzNzc2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxNDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjZjMyZmU3ZmE0NzM4MThkYzZlNTQ3YjM2M2ZlZTBhZTM4OGM0OWJmM2I1NjNiY2YyYTk0OWJkZjIwYTNlODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OYkc5VGqNFxzJzSoD8LreK6o602gEVWrjFEwK9Gwoo8)
![image](https://private-user-images.githubusercontent.com/50374470/389587509-0a1e9903-25d7-4b64-89f1-e836eadf8ef1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODM0NDgsIm5iZiI6MTczOTQ4MzE0OCwicGF0aCI6Ii81MDM3NDQ3MC8zODk1ODc1MDktMGExZTk5MDMtMjVkNy00YjY0LTg5ZjEtZTgzNmVhZGY4ZWYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxNDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYzZWI1ZmVkNTYzNmUxOTNkOGE2M2FkNGViYzQwYzFlMmViZTQ1YjM1OWU0Y2JiNDViN2NmOTc4Y2M2YWM3YzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.q5wvUVQ3YyVgvvsBVsvfo48bLK_PAkI1i0djJxuV-V0)
before:
after:
![image](https://private-user-images.githubusercontent.com/50374470/389587928-595d6102-2c07-472f-a82f-53c23c8008aa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODM0NDgsIm5iZiI6MTczOTQ4MzE0OCwicGF0aCI6Ii81MDM3NDQ3MC8zODk1ODc5MjgtNTk1ZDYxMDItMmMwNy00NzJmLWE4MmYtNTNjMjNjODAwOGFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxNDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmMDI5NzdhYjE2NTkzNzIyMjBkZGViZWZmYmZiZmJlMDE3ZjA0MzcxZTRkYWM5MDc3YmFjYmEzNDRmNTVkYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.UdhCmAXsaJgFi4QX-D-T33Th39ZRJZymeC0d_fYfn54)
![image](https://private-user-images.githubusercontent.com/50374470/389588284-9a7f753b-a1a9-4539-b761-6dabf088d50e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0ODM0NDgsIm5iZiI6MTczOTQ4MzE0OCwicGF0aCI6Ii81MDM3NDQ3MC8zODk1ODgyODQtOWE3Zjc1M2ItYTFhOS00NTM5LWI3NjEtNmRhYmYwODhkNTBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDIxNDU0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliMWI0NTQxMWM5NTIwMWIzNDQ1YTUwMjIzM2UyNGMxZTY1Yjc5MDZiYmU0Yzk1OTk0ZGIwZGFhZGYxNjVkM2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.3wykYLcCYPLU6VWO0RICEKZA-LBW7087NCE7ssMunh4)
Manually test the debug page.
I used npm run start debug and added a markers-altitude.html debugging page
Write tests for all new functionality and make sure the CI checks pass.
I used npm run test and it passed the test
Document any changes to public APIs.
/src/ui/marker.ts -> line:58
/src/ui/popup.ts -> line:80
this PR includes style spec API or visual changes.
@mapbox/static-apis @mapbox/map-design-team
Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes.@mapbox/gl-native
if this PR includes shader changes or needs a native port.