Replaces EPSG:4326 with OGC:CRS84 in GL JS LngLat doc
#11072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlet
added
docs 📜
skip changelog
SnailBones
reviewed
Sep 30, 2021
src/geo/lng_lat.js
Outdated
| * [GeoJSON specification](https://tools.ietf.org/html/rfc7946). | ||
| * These coordinates use longitude, latitude coordinate order (as opposed to latitude, longitude) | ||
| * to match the [GeoJSON specification](https://datatracker.ietf.org/doc/html/rfc7946#section-4), | ||
| * which is equivalent to the [OGC:CRS84 coordinate reference system](https://datatracker.ietf.org/doc/html/rfc7946#section-4). |
There was a problem hiding this comment.
Nit: Do we need the same link twice?
There was a problem hiding this comment.
@SnailBones great catch, removed 2nd link in 54201b8 👍🏼
|
@danswick related to https://github.com/mapbox/help/pull/3139#issuecomment-915373648 – do you think there's an opportunity (or need) here to add a link to our projection glossary entry? |
SnailBones
approved these changes
Oct 1, 2021
danswick
approved these changes
Oct 15, 2021
katydecorah
pushed a commit
that referenced
this pull request
Oct 20, 2021
* main: Add touch pan blocker to gesture handling for touch devices (#11116) Address accessibility issues (#11064) add support for non-mercator projections (#11124) Image fallback expressions within paint properties (#11049) Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072) Add globe view support to heatmap shaders (#11120) Exclude flaky test (#11118) consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113) Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114) render-test-flakiness:clear worker storage (#11111) upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110) Added v1.13.2 changelog entry (#11108) One weird JSON.parse() trick (#11098) Fixed doc usage of map.getCenter (#11093) s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795) Update link to transpiling guide (#11096) Cherry pick 2.5.1 changelog (#11099) Fix an iOS15 issue where Safari tab bar interrupts panning (#11084) Fix conditional check for isFullscreen to accommodate Safari (#11086) Render tests for #11041 (#11070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re:
changes
@sgillies noted that EPSG:4326 has historically followed both lng,lat and lat,lng coordinate orders. Referencing such a thing can add to user confusion, so this PR removes a EPSG:4326 reference in the GL JS
LngLatdoc and replaces it with a reference to OGC:CRS84.before/after screenshot
Launch Checklist