Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equalWithPrecision assertion always passes #4730

Closed
IvanSanchez opened this issue May 22, 2017 · 0 comments
Closed

equalWithPrecision assertion always passes #4730

IvanSanchez opened this issue May 22, 2017 · 0 comments

Comments

@IvanSanchez
Copy link
Contributor

When trying to whip up some unit tests for #4726, I noticed that the behaviour of the equalWithPrecision assertion defined in test/node_modules/mapbox-gl-js-test.js is pretty much broken.

I mean, I can go to https://github.com/mapbox/mapbox-gl-js/blob/master/test/unit/style-spec/function.test.js#L77 , and change

t.equalWithPrecision(f(2), 30 / 9, 1e-6);

into

t.equalWithPrecision(f(2), 123456789, 1e-6);

and the unit tests will still pass.

IvanSanchez added a commit to IvanSanchez/mapbox-gl-js that referenced this issue May 22, 2017
jfirebaugh pushed a commit that referenced this issue May 22, 2017
chrisvoll pushed a commit to chrisvoll/mapbox-gl-js that referenced this issue May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant