Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "StyleLayer#paint" and "StyleLayer#layout" #3044

Closed
lucaswoj opened this issue Aug 22, 2016 · 3 comments · Fixed by #5682
Closed

Deprecate "StyleLayer#paint" and "StyleLayer#layout" #3044

lucaswoj opened this issue Aug 22, 2016 · 3 comments · Fixed by #5682

Comments

@lucaswoj
Copy link
Contributor

StyleLayer#paint and StyleLayer#layout do not accommodate for data-driven styling. Any code that uses these properties probably doesn't accommodate for data-driven styling either. We should deprecate these properties in favor of StyleLayer#getPaintValue and StyleLayer#getLayoutValue. This might be done in conjunction with #2739.

cc @davidtheclark

@davidtheclark
Copy link
Contributor

@lucaswoj So this is the root of the problem I was seeing? — that queryRenderedFeatures seemed to always look for circles that are as large as they might be instead of as large as they actually are?

@lucaswoj
Copy link
Contributor Author

@davidtheclark Worse, actually. queryRenderedFeatures assumed all circles were the size specified in the first function stop 😬

@jfirebaugh
Copy link
Contributor

I think we need to do this before adding further data-driven properties -- it's hiding a lot of bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants