Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rendering for data-driven text-size + icon-text-fit #5631

Closed
jfirebaugh opened this issue Nov 9, 2017 · 0 comments
Closed

Wrong rendering for data-driven text-size + icon-text-fit #5631

jfirebaugh opened this issue Nov 9, 2017 · 0 comments
Assignees
Labels

Comments

@jfirebaugh
Copy link
Contributor

This is a specific example of #3044:

size = layout['text-size'] / 24,

If text-size is data-driven, this code is incorrect. What needs to happen is that the evaluated value for the current feature is passed in. Here's native implementing that:

https://github.com/mapbox/mapbox-gl-native/blob/a71756ea8d62cb448963a59e215e1324cfd57d9f/src/mbgl/text/quads.cpp#L18

@jfirebaugh jfirebaugh self-assigned this Nov 9, 2017
@jfirebaugh jfirebaugh changed the title Wrong rendering for data-driven icon-size + icon-text-fit Wrong rendering for data-driven text-size + icon-text-fit Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant