Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout properties for icon behaves strange #2092

Closed
AbrahamArun opened this issue Feb 9, 2016 · 7 comments · Fixed by #2095
Closed

Layout properties for icon behaves strange #2092

AbrahamArun opened this issue Feb 9, 2016 · 7 comments · Fixed by #2095
Assignees

Comments

@AbrahamArun
Copy link

  let pinLayer = {
    'id':'pin',
    'type': 'symbol',
    'source':'location-pin',

    'layout': {
      'icon-image': 'map-pin'
      //'icon-allow-overlap': true,
      //'icon-ignore-placement': true
    },
    'interactive' : false,
    'minzoom': minZoom,
    'maxzoom': maxZoom
  };

map.addLayer(pinLayer);

On switching to the latest version 0.14.0, I have observed that the style breaks on icon-allow-overlap and icon-ignore-placement.

On commenting those properties, the map looks like this (expected)
screen shot 2016-02-09 at 5 53 02 pm

And on adding those properties, the map renders like this
screen shot 2016-02-09 at 5 53 34 pm

P.S.: I am using the style 'bright-v8'. And this is also the case with text-allow-overlap and text-ignore-placement

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 9, 2016

Any intuition on this @ansis?

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 9, 2016

Live demo

@AbrahamArun
Copy link
Author

@lucaswoj That was neat, I was lazy to write a fiddle.

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 9, 2016

This bug blames to b21b4c3

@ansis
Copy link
Contributor

ansis commented Feb 9, 2016

I think we're not properly enabling and disabling the stencil test.

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 9, 2016

@ansis Exactly. I already submitted a PR for your 👀

@lucaswoj
Copy link
Contributor

the fix for this bug was just released in v0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants