Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift zooming is swoopy #2070

Closed
aaronlidman opened this issue Feb 5, 2016 · 1 comment · Fixed by #2128
Closed

Shift zooming is swoopy #2070

aaronlidman opened this issue Feb 5, 2016 · 1 comment · Fixed by #2128

Comments

@aaronlidman
Copy link

zoomz

I'm noticing if I shift zoom to a location that isn't centered, it will zoom to the center and then shift over to the spot. This feels very weird. I'm on the latest Chrome.

Is this intentional or maybe a regression? I don't recall it feeling like this before.

cc @ansis @bhousel
@ansis ansis mentioned this issue Feb 9, 2016
Closed
@aaronlidman
Copy link
Author

You can see it better in the video here: https://www.mapbox.com/blog/map-ios-sdk-app-screencast/

ansis added a commit that referenced this issue Feb 16, 2016
@ansis
make panning while zooming more linear
14b0c6d 
fix #2070

easeTo used to interpolate locations based on projected values. As zoom
changed the new screen distance of these projected values changed either
speeding up or slowing down the panning.

With this change, the new center moves across the screen from it's
previous point location to it's new point location linearly.
@ansis ansis mentioned this issue Feb 16, 2016
Merged
@ansis ansis self-assigned this Feb 16, 2016
ansis added a commit that referenced this issue Feb 16, 2016
@ansis
make panning while zooming more linear
143f358 
fix #2070

easeTo used to interpolate locations based on projected values. As zoom
changed the new screen distance of these projected values changed either
speeding up or slowing down the panning.

With this change, the new center moves across the screen from it's
previous point location to it's new point location linearly.
@jfirebaugh jfirebaugh assigned bhousel and unassigned ansis Feb 16, 2016
@lucaswoj lucaswoj assigned bhousel and unassigned ansis Feb 16, 2016
@bhousel bhousel removed their assignment Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make panning while zooming more linear mapbox/mapbox-gl-js
4 participants
@bhousel @aaronlidman @lucaswoj @ansis