Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate Tile's style zoom level from it's data zoom level #1912

Closed
ansis opened this issue Jan 8, 2016 · 2 comments
Closed

separate Tile's style zoom level from it's data zoom level #1912

ansis opened this issue Jan 8, 2016 · 2 comments
Labels
feature 🍏

Comments

@ansis
Copy link
Contributor

ansis commented Jan 8, 2016

The current implementation of overscaled tile reparsing abuses the z coordinate to store the zoom level that needs to be used for style parsing. The real z is recovered using sourceMaxZoom. It's really hard to follow how this works or if it works.

A TileCoord should have two separate z's. One for the style and one for the actual vectortile.
@lucaswoj
Copy link
Contributor

lucaswoj commented Jan 8, 2016

ref #1909

@lucaswoj lucaswoj mentioned this issue Jan 8, 2016
Merged
@ansis ansis mentioned this issue Jan 25, 2016
Closed
ansis added a commit that referenced this issue Jan 27, 2016
@ansis
store both style and data zoom levels in TileCoord
c51bc55 
fixes #1912

TileCoord's constructor now requires `sourceMaxZoom`, which is used to
calculate the TileCoord's data zoom level and for calculating child and
parent TileCoords.

The goal is to contain all the weird logic for representing overscaled
tiles within TileCoord.
@ansis ansis mentioned this issue Jan 27, 2016
Closed
@ansis ansis self-assigned this Jan 27, 2016
@ansis ansis removed their assignment Mar 17, 2016
@lucaswoj
Copy link
Contributor

Closing in favor of #2868 which highlights user-facing behaviour and doesn't specify an implementation.

This was referenced Jul 29, 2016
Closed
Closed
@mourner mourner mentioned this issue Apr 11, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move overscaled tile zoom level logic further into TileCoord mapbox/mapbox-gl-js
3 participants
@mourner @lucaswoj @ansis