Fixed binary search end case bug and added more complete tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdumont
reviewed
Mar 27, 2017
| if (currentValue === input) { | ||
| currentIndex += 1; | ||
| break; | ||
| upperValue = stops[currentIndex + 1][0]; |
There was a problem hiding this comment.
Note: you might want to handle the case where n==1 in this function since this new line would be problematic with n==1. (ie: don't rely on the caller doing the n==1 check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in my binary search code that would cause off-by-one errors on odd indices for interpolated values. I confirmed that was an issue in isolation, and I believe it is the cause of the bug being observed here: mapbox/mapbox-gl-js#3838
This PR should fix that bug by having a correct end search case for this flavor of binary search, where we want to return the lower index if a value is interpolated (not just exact matches).
This wasn't caught with our old tests because we only were using one, two, or three stops. I added a more complete test case with 13 not-evenly-spaced stops based on real user data from the issue above.
cc/ @lucaswoj @mourner
fixes mapbox/mapbox-gl-js#3838