Race condition loading shapes #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the draw control is in its final state when the event is fired so that it is safe for anything responding to the event to make changes to the draw instance
|
@nigelsim - sorry for the delayed follow up. I got a chance to sit down with this today and all looks well. I'm working on rolling a new release and show have this out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in my support request, we are unable to make Mapbox Draw correctly render features added before the control has fully loaded, but there are no events or otherwise to properly indicate that the control is ready.
This PR forces the
ctx.storeto be dirty when doing the initial rendering following adding its layers.The issue is that the
rendercleanup()function is being called even if the map isn't ready yet, and this function setsstore.isDirty=false, meaning that any unrendered features are ignored.I've also changed the order of operations for the
draw.renderevent for a similar reason, so that changes made to the draw instance in response to this event aren't immediately forgotten.