-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate switching between hot and cold sources #1026
base: main
Are you sure you want to change the base?
Conversation
This switching causes severe flickering and there seems to be no performance advantage at least in our use case. See: <mapbox#871> <mapbox#916>
It reduces the number of layers in the map. In my case, i would say that it even improves performance ! Thanks @vhautsal |
This solves a flicker issue I was having. Hope it gets merged soon 🎉 |
Adding for reference #296 |
Hi @vhautsal, Thanks for the contribution, and sorry for the delayed response! Could you please rebase on top of the |
We are facing flicker issue also; would be great to get this merged! @vhautsal @stepankuzmin |
any update on this? |
Bump - we need this fix in please. The flickering of the map caused by the issue is not good |
Please do merge it why delaying, app does not look good with flickering. |
nudge |
Hi @vhautsal Any update on this PR? |
Unfortunately there's not much I can do. I synced my branch with upstream a year ago, but nothing happened then. Apparently there are some new conflicts now, but after nearly four years of waiting, I'm not interested in trying to keep up unless some Mapbox API change forces us to update. @LukasGrubis @stepankuzmin |
Switching between two sources causes severe flickering and there seems to be no performance advantage at least in our use case.
Related issues:
#871
#916