Make indicator submission/edit convert csv to json #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
changed the title
|
cc: @dereklieu |
|
I think |
|
@kamicut this works now by changing tabs to commas on change and doing live validation, it occasionally warns with: Failed prop type: Invalid prop `value` of type `array` supplied to `TextWidget`, expected `string`
Failed prop type: Invalid prop `formData` supplied to `StringField`.but I'm not positive why; works though... |
kamicut
reviewed
Nov 18, 2016
| @@ -30,12 +40,20 @@ class NewIndicator extends React.Component { | |||
| }); | |||
| } | |||
|
|
|||
| handleChange (e) { | |||
There was a problem hiding this comment.
Since there's duplication between NewIndicator and EditIndicator, do you think this textfield should be its own widget?
There was a problem hiding this comment.
Yup, do you want ticket that out as a separate refactor?
This was referenced Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kamicut this isn't finished yet (no display parsing) but do you think the csv conversion can just be wrapped in a
try/catchblock to display errors while parsing?