Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate _module in favor of _esm #66

Merged
merged 1 commit into from
Feb 11, 2023
Merged

chore: deprecate _module in favor of _esm #66

merged 1 commit into from
Feb 11, 2023

Conversation

manzt
Copy link
Owner

@manzt manzt commented Feb 11, 2023

Requires users to specify _esm instead of the legacy _module, for their widget JavaScript code. We previously supported both, but I don't think this is necessary at v0.1 our docs only use _esm so the legacy syntax is very hidden.

@netlify
Copy link

netlify bot commented Feb 11, 2023

Deploy Preview for anywidget canceled.

Name Link
🔨 Latest commit 022fc66
🔍 Latest deploy log https://app.netlify.com/sites/anywidget/deploys/63e7dd4054858c00085abaff

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #66 (022fc66) into main (8df3760) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   98.28%   98.29%   +0.01%     
==========================================
  Files           7        7              
  Lines         349      352       +3     
==========================================
+ Hits          343      346       +3     
  Misses          6        6              
Impacted Files Coverage Δ
anywidget/widget.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manzt manzt merged commit a195465 into main Feb 11, 2023
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
@manzt manzt deleted the deprecate-module branch March 24, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant