Bagatur/fix doc ci (langchain-ai#12529)

manukychen · Oct 29, 2023 · 0b4b9e6 · 0b4b9e6
1 parent 2424fff
commit 0b4b9e6
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 14 deletions.
diff --git a/.github/workflows/doc_lint.yml b/.github/workflows/doc_lint.yml
@@ -9,6 +9,8 @@ on:
       - 'docs/**'
       - 'templates/**'
       - 'cookbook/**'
+      - '.github/workflows/_lint.yml'
+      - '.github/workflows/doc_lint.yml'
   workflow_dispatch:
 
 jobs:
@@ -23,12 +25,11 @@ jobs:
       run: |
         # We should not encourage imports directly from main init file
         # Expect for hub
-        git grep 'from langchain import' {docs,templates,cookbook} | grep -vE 'from langchain import (hub)' && exit 1 || exit 0
+        git grep 'from langchain import' {docs/docs,templates,cookbook} | grep -vE 'from langchain import (hub)' && exit 1 || exit 0
 
-    - name: Run lint
+  lint:
       uses:
         ./.github/workflows/_lint.yml
       with:
-        working-directory: .
-      secrets: inherit
-
+        working-directory: "."
+      secrets: inherit
diff --git a/Makefile b/Makefile
@@ -42,12 +42,12 @@ spell_fix:
 ######################
 
 lint:
-	poetry run ruff {docs,templates,cookbook}
-	poetry run black {docs,templates,cookbook} --check
+	poetry run ruff docs templates cookbook
+	poetry run black docs templates cookbook --check
 
 format format_diff:
-	poetry run black {docs,templates,cookbook}
-	poetry run ruff --select I --fix {docs,templates,cookbook}
+	poetry run black docs templates cookbook
+	poetry run ruff --select I --fix docs templates cookbook
 
 ######################
 # HELP

diff --git a/docs/docs/guides/safety/amazon_comprehend_chain.ipynb b/docs/docs/guides/safety/amazon_comprehend_chain.ipynb
@@ -232,7 +232,7 @@
   {
    "cell_type": "code",
    "execution_count": null,
-   "id": "a25e6f93-765b-4f99-8c1c-929157dbd4aa",
+   "id": "082c6cfc",
    "metadata": {
     "tags": []
    },
@@ -562,7 +562,7 @@
    },
    "outputs": [],
    "source": [
-    "from langchain import HuggingFaceHub\n",
+    "from langchain.llms import HuggingFaceHub\n",
     "from langchain.prompts import PromptTemplate\n",
     "\n",
     "template = \"\"\"{question}\"\"\"\n",
@@ -690,7 +690,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "from langchain import SagemakerEndpoint\n",
+    "from langchain.llms import SagemakerEndpoint\n",
     "from langchain.llms.sagemaker_endpoint import LLMContentHandler\n",
     "from langchain.prompts import PromptTemplate\n",
     "import json\n",
@@ -1414,7 +1414,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.10.6"
+   "version": "3.9.1"
   }
  },
  "nbformat": 4,

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -37,6 +37,14 @@ black = "^23.10.0"
 codespell = "^2.2.0"
 
 
+[tool.poetry.group.dev.dependencies]
+
+
+[tool.poetry.group.test.dependencies]
+
+
+[tool.poetry.group.typing.dependencies]
+
 [tool.codespell]
 skip = '.git,*.pdf,*.svg,*.pdf,*.yaml,*.ipynb,poetry.lock,*.min.js,*.css,package-lock.json,example_data,_dist,examples,templates'
 # Ignore latin etc