-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R] added debug_traceCall #940
Conversation
l2geth/eth/api_tracer.go
Outdated
statedb, header, err := api.eth.APIBackend.StateAndHeaderByNumberOrHash(ctx, blockNrOrHash) | ||
|
||
if statedb == nil || err != nil { | ||
return nil, fmt.Errorf("Error retrieving state") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If err
is not nil, please include err message to returned error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check whether err
is nil
or not.
Do we have referenced implementation? |
|
we do have an API at l2geth/eth/api_tracer.go L:723, Is this API serve for the same purpose? |
The existing tx tracer can only trace the exiting tx. However, the new api can trace arbitrary transactions on top of current chain. |
The base branch was changed.
Goals of PR
Adding
debug_traceCall
to the list of RPC methodsCore changes:
debug_traceCall
Notes:
debug_traceCall
for state verificationI couldn't find internal tests to test RPC methods, so I manually tested them.
l2geth
in dev mode