[R4R] - {0.4.2}: Bugfix/sigma mnt 11 #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sha3nS
requested review from
wukongcheng,
bradyjoestar,
abelliumnt,
agnarsong,
guoshijiang,
byteflyfunny and
shidaxi
as code owners
byteflyfunny
previously approved these changes
Jun 27, 2023
abelliumnt
reviewed
Jun 27, 2023
| import ( | ||
| "fmt" | ||
| "github.com/stretchr/testify/require" | ||
| "testing" |
abelliumnt
reviewed
Jun 27, 2023
| @@ -252,3 +255,27 @@ func TestIsMarkerContext(t *testing.T) { | |||
| } | |||
| require.True(t, batchContext.IsMarkerContext()) | |||
| } | |||
|
|
|||
| func TestReadUint64(t *testing.T) { | |||
| readUint64 := func(r io.Reader, val *uint64, n uint) error { | |||
There was a problem hiding this comment.
Why do you define readUint64 again here? Can we just call the readUint64 in batch-submitter/drivers/sequencer/encoding.go?
There was a problem hiding this comment.
test file is in a different package, can't reference an unexported method
Sha3nS
force-pushed
the
bugfix/sigma-MNT-11
branch
from
609665b
to
b452e65
Compare
Sha3nS
force-pushed
the
bugfix/sigma-MNT-11
branch
from
b452e65
to
95b3821
Compare
abelliumnt
approved these changes
Jun 27, 2023
guoshijiang
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of PR
Core changes:
fix sigma audit MNT-11
Notes:
no
Related Issues:
TBD